He is most famous for his regular role of Battery Sergeant-Major Williams on It Ain't Half Hot Mum and Olive Smallbridge on Never the Twain. He is also known for his roles in two "Carry On" films. His television guest appearances included roles on UFO, Coronation Street, Adam Adamant Lives!, Softly, Softly, The Mind of Mr. J. G. Reeder, The Onedin Line, Callan, Softly, Softly: Taskforce, Dixon of Dock Green, Z-Cars, Billy Liar and Sergeant Cork.